Update no_model_utils.py #913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhamer
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
reviewed
Jul 23, 2024
| f"or remove the field from tensor_fields when calling add_documents to make your content" | ||
| f"only available for lexical search or filtering." | ||
| f"If vectorisation is needed, please re-create the index a different model.") |
| f"This model is intended for adding documents and searching with custom vectors only." | ||
| f"If searching using this index, you can set the search_method to LEXICAL for lexical search, " | ||
| f"or remove the field from tensor_fields when calling add_documents to make your content" |
There was a problem hiding this comment.
Only correct for unstructured indexes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Update error message for adding documents or searching with no_model
What is the current behavior? (You can also link to an open issue here)
Error is not descriptive and incorrect as it is possible to add and search text with lexical search in a no_model index.
What is the new behavior (if this is a feature change)?
Additional context added to error message
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Unit tests need to be run - @farshidz can you have someone pick this up?
Related Python client changes (link commit/PR here)
None
Related documentation changes (link commit/PR here)
None
Other information:
Please check if the PR fulfills these requirements